fixes a null check issue

2017-04-27 11:58:49 +10:00
parent baebd73f19
commit 70650eff6a
1 changed files with 7 additions and 3 deletions
@@ -23,13 +23,17 @@ namespace OurUmbraco.Repository.Models

        public bool Equals(PackageVersionSupport other)
        {
+            if (ReferenceEquals(null, other)) return false;
+            if (ReferenceEquals(this, other)) return true;
            return _fileId == other._fileId;
        }

        public override bool Equals(object obj)
        {
            if (ReferenceEquals(null, obj)) return false;
-            return obj is PackageVersionSupport && Equals((PackageVersionSupport)obj);
+            if (ReferenceEquals(this, obj)) return true;
+            if (obj.GetType() != this.GetType()) return false;
+            return Equals((PackageVersionSupport) obj);
        }

        public override int GetHashCode()
@@ -39,12 +43,12 @@ namespace OurUmbraco.Repository.Models

        public static bool operator ==(PackageVersionSupport left, PackageVersionSupport right)
        {
-            return left.Equals(right);
+            return Equals(left, right);
        }

        public static bool operator !=(PackageVersionSupport left, PackageVersionSupport right)
        {
-            return !left.Equals(right);
+            return !Equals(left, right);
        }
    }
 }