From 70650eff6a339111671497193babcc6f439e9c2f Mon Sep 17 00:00:00 2001 From: Shannon Date: Thu, 27 Apr 2017 11:58:49 +1000 Subject: [PATCH] fixes a null check issue --- OurUmbraco/Repository/Models/PackageVersionSupport.cs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/OurUmbraco/Repository/Models/PackageVersionSupport.cs b/OurUmbraco/Repository/Models/PackageVersionSupport.cs index 5a22afc0..49b1e174 100644 --- a/OurUmbraco/Repository/Models/PackageVersionSupport.cs +++ b/OurUmbraco/Repository/Models/PackageVersionSupport.cs @@ -23,13 +23,17 @@ namespace OurUmbraco.Repository.Models public bool Equals(PackageVersionSupport other) { + if (ReferenceEquals(null, other)) return false; + if (ReferenceEquals(this, other)) return true; return _fileId == other._fileId; } public override bool Equals(object obj) { if (ReferenceEquals(null, obj)) return false; - return obj is PackageVersionSupport && Equals((PackageVersionSupport)obj); + if (ReferenceEquals(this, obj)) return true; + if (obj.GetType() != this.GetType()) return false; + return Equals((PackageVersionSupport) obj); } public override int GetHashCode() @@ -39,12 +43,12 @@ namespace OurUmbraco.Repository.Models public static bool operator ==(PackageVersionSupport left, PackageVersionSupport right) { - return left.Equals(right); + return Equals(left, right); } public static bool operator !=(PackageVersionSupport left, PackageVersionSupport right) { - return !left.Equals(right); + return !Equals(left, right); } } } \ No newline at end of file