swcs/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplified value check using type pattern matching

Browse Source
This commit is contained in:
Ronald Barendse
2020-06-11 00:49:44 +02:00
parent c3e58df3b5
commit eac6351c3f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Umbraco.Core/PropertyEditors/PropertyValueConverterBase.cs
+2 -2
View File
@@ -18,7 +18,7 @@ namespace Umbraco.Core.PropertyEditors
case PropertyValueLevel.Source:
// the default implementation uses the old magic null & string comparisons,
// other implementations may be more clever, and/or test the final converted object values
return value != null && (!(value is string) || string.IsNullOrWhiteSpace((string)value) == false);
return value != null && (!(value is string stringValue) || !string.IsNullOrWhiteSpace(stringValue));
case PropertyValueLevel.Inter:
return null;
case PropertyValueLevel.Object:
@@ -32,7 +32,7 @@ namespace Umbraco.Core.PropertyEditors
public virtual bool HasValue(IPublishedProperty property, string culture, string segment)
{
var value = property.GetSourceValue(culture, segment);
return value != null && (!(value is string) || string.IsNullOrWhiteSpace((string)value) == false);
return value != null && (!(value is string stringValue) || !string.IsNullOrWhiteSpace(stringValue));
}
public virtual Type GetPropertyValueType(IPublishedPropertyType propertyType)