feat(build): Treat build warnings as errors

.github/workflows/release.yml

@@ -5,6 +5,11 @@ on:
     branches: [ master ]
     tags: [ v*.*.* ]
 
+env:
+  DOTNET_NOLOGO: true
+  DOTNET_CLI_TELEMETRY_OPTOUT: true
+  DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
+
 jobs:
   build-artifacts:
     strategy:
@@ -14,11 +19,6 @@ jobs:
           - VMelnalksnis.NordigenDotNet.DependencyInjection
     
     runs-on: ubuntu-latest
-    env:
-      DOTNET_NOLOGO: true
-      DOTNET_CLI_TELEMETRY_OPTOUT: true
-      DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
-
     steps:
       - uses: actions/checkout@v3.0.2
 

.github/workflows/test.yml

@@ -8,15 +8,15 @@ on:
   pull_request:
     branches: [ master ]
 
+env:
+  DOTNET_NOLOGO: true
+  DOTNET_CLI_TELEMETRY_OPTOUT: true
+  DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
+
 jobs:
   run-tests:
     name: Run tests
     runs-on: ubuntu-latest
-    env:
-      DOTNET_NOLOGO: true
-      DOTNET_CLI_TELEMETRY_OPTOUT: true
-      DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
-
     steps:
       - uses: actions/checkout@v3.0.2
 
@@ -29,7 +29,13 @@ jobs:
         run: dotnet restore
 
       - name: Build
-        run: dotnet build --configuration Release --no-restore /nologo /clp:NoSummary
+        run: >
+          dotnet build
+          --configuration Release
+          --no-restore
+          /warnAsError
+          /nologo
+          /clp:NoSummary
 
       - name: Run Tests
         run: >
@@ -47,6 +53,8 @@ jobs:
         uses: VMelnalksnis/resharper-inspect-action@v0.2.3
         with:
           solution: NordigenDotNet.sln
+          resharper-version: 2022.1.2
+          treat-warnings-as-errors: true
 
       - name: Gather Code Coverage
         if: github.event.schedule == null

deployment/publish.sh

@@ -12,6 +12,7 @@ dotnet pack \
 	-p:AssemblyFileVersion="$full_version" \
 	-p:PackageVersion="$version" \
 	-p:InformationalVersion="$version""$3" \
+	/warnAsError \
 	/nologo ||
 	exit