Compare commits

..

9 Commits

Author SHA1 Message Date
kgiszewski 3d25f75fb9 Bump version number to v1.7.3 2015-04-16 08:54:36 -04:00
kgiszewski 6fa713f88e Change to the internal event 2015-04-15 15:32:08 -04:00
kgiszewski d9982fe3a2 Merge branch 'master' of github.com:imulus/Archetype 2015-04-15 15:30:11 -04:00
kgiszewski 588bdfe429 Update to Tom's latest packager 2015-04-15 15:30:03 -04:00
Kevin Giszewski 0174f6d78b Merge pull request #262 from kjac/submit-watcher
Fix #261
2015-04-15 15:29:33 -04:00
Kevin Giszewski 84144b6206 Update Readme 2015-04-10 11:27:11 -04:00
kjac 27910e8d22 Fix #261
Add a watch to the "formSubmitting" event for each property added to a
fieldset, to make sure Archetype gets the last say in the
"formSubmitting" event.
2015-04-04 21:57:49 +02:00
Tom Fulton 9bf413207f Fix logic issue with assemblyinfo patcher 2015-04-02 23:24:54 -06:00
kgiszewski e5cd3d0cb0 Bump Version to 1.7.2 2015-03-31 11:04:57 -04:00
9 changed files with 76 additions and 14 deletions
+2 -1
View File
@@ -55,6 +55,7 @@ module.exports = function(grunt) {
'app/controllers/controller.js',
'app/controllers/config.controller.js',
'app/directives/archetypeproperty.js',
'app/directives/archetypesubmitwatcher.js',
'app/directives/archetypecustomview.js',
'app/directives/localize.js',
'app/services/localization.js',
@@ -166,7 +167,7 @@ module.exports = function(grunt) {
files: ['app/Umbraco/Umbraco.Archetype/Archetype.Umbraco.csproj'],
filename: 'VersionInfo.cs',
info: {
version: '<%= (pkgMeta.version.indexOf("-") ? pkgMeta.version.substring(0, pkgMeta.version.indexOf("-")) : pkgMeta.version) %>',
version: '<%= (pkgMeta.version.indexOf("-") > 0 ? pkgMeta.version.substring(0, pkgMeta.version.indexOf("-")) : pkgMeta.version) %>',
fileVersion: '<%= pkgMeta.version %>'
}
}
+1 -1
View File
@@ -9,7 +9,7 @@ Install the selected <a href='https://github.com/imulus/Archetype/releases'>rele
## Official Docs ##
http://imulus.github.io/Archetype
https://github.com/kgiszewski/ArchetypeManual
Follow us on Twitter https://twitter.com/ArchetypeKit
@@ -1,4 +1,4 @@
using System.Reflection;
[assembly: AssemblyVersion("1.7.1")]
[assembly: AssemblyFileVersion("1.7.1")]
[assembly: AssemblyVersion("1.7.3")]
[assembly: AssemblyFileVersion("1.7.3")]
+15
View File
@@ -299,6 +299,8 @@
$scope.model.value.toString = stringify;
}
}
// reset submit watcher counter on save
$scope.activeSubmitWatcher = 0;
});
//helper to count what is visible
@@ -398,4 +400,17 @@
{
assetsService.loadCss($scope.model.config.customCssPath);
}
// submit watcher handling:
// because some property editors use the "formSubmitting" event to set/clean up their model.value,
// we need to monitor the "formSubmitting" event from a custom property and broadcast our own event
// to forcefully update the appropriate model.value's
$scope.activeSubmitWatcher = 0;
$scope.submitWatcherOnLoad = function () {
$scope.activeSubmitWatcher++;
return $scope.activeSubmitWatcher;
}
$scope.submitWatcherOnSubmit = function () {
$scope.$broadcast("archetypeFormSubmitting");
}
});
+29 -8
View File
@@ -86,7 +86,7 @@ angular.module("umbraco.directives").directive('archetypeProperty', function ($c
});
});
scope.$on("formSubmitting", function (ev, args) {
scope.$on("archetypeFormSubmitting", function (ev, args) {
// validate all fieldset properties
_.each(scope.fieldset.properties, function (property) {
validateProperty(scope.fieldset, property);
@@ -102,6 +102,7 @@ angular.module("umbraco.directives").directive('archetypeProperty', function ($c
ngModelCtrl.$setValidity(validationKey, scope.fieldset.isValid);
});
// called when the value of any property in a fieldset changes
function propertyValueChanged(fieldset, property) {
// it's the Umbraco way to hide the invalid state when altering an invalid property, even if the new value isn't valid either
@@ -158,6 +159,14 @@ angular.module("umbraco.directives").directive('archetypeProperty', function ($c
return _.unique(propertyAliasParts).reverse().join("-");
};
var getFieldset = function(scope) {
return scope.archetypeRenderModel.fieldsets[scope.fieldsetIndex];
}
var getFieldsetProperty = function (scope) {
return getFieldset(scope).properties[scope.renderModelPropertyIndex];
}
function loadView(view, config, defaultValue, alias, propertyAlias, scope, element, ngModelCtrl, propertyValueChanged) {
if (view)
{
@@ -174,14 +183,15 @@ angular.module("umbraco.directives").directive('archetypeProperty', function ($c
scope.model.config = {};
//ini the property value after test to make sure a prop exists in the renderModel
var renderModelPropertyIndex = getPropertyIndexByAlias(scope.archetypeRenderModel.fieldsets[scope.fieldsetIndex].properties, alias);
scope.renderModelPropertyIndex = getPropertyIndexByAlias(getFieldset(scope).properties, alias);
if (!renderModelPropertyIndex)
if (!scope.renderModelPropertyIndex)
{
scope.archetypeRenderModel.fieldsets[scope.fieldsetIndex].properties.push(JSON.parse('{"alias": "' + alias + '", "value": "' + defaultValue + '"}'));
renderModelPropertyIndex = getPropertyIndexByAlias(scope.archetypeRenderModel.fieldsets[scope.fieldsetIndex].properties, alias);
getFieldset(scope).properties.push(JSON.parse('{"alias": "' + alias + '", "value": "' + defaultValue + '"}'));
scope.renderModelPropertyIndex = getPropertyIndexByAlias(getFieldset(scope).properties, alias);
}
scope.model.value = scope.archetypeRenderModel.fieldsets[scope.fieldsetIndex].properties[renderModelPropertyIndex].value;
scope.renderModel = {};
scope.model.value = getFieldsetProperty(scope).value;
//set the config from the prevalues
scope.model.config = config;
@@ -208,10 +218,21 @@ angular.module("umbraco.directives").directive('archetypeProperty', function ($c
//watch for changes since there is no two-way binding with the local model.value
scope.$watch('model.value', function (newValue, oldValue) {
scope.archetypeRenderModel.fieldsets[scope.fieldsetIndex].properties[renderModelPropertyIndex].value = newValue;
getFieldsetProperty(scope).value = newValue;
// notify the linker that the property value changed
propertyValueChanged(scope.archetypeRenderModel.fieldsets[scope.fieldsetIndex], scope.archetypeRenderModel.fieldsets[scope.fieldsetIndex].properties[renderModelPropertyIndex]);
propertyValueChanged(getFieldset(scope), getFieldsetProperty(scope));
});
scope.$on('archetypeFormSubmitting', function (ev, args) {
// did the value change (if it did, it most likely did so during the "formSubmitting" event)
var currentValue = getFieldsetProperty(scope).value;
if (currentValue != scope.model.value) {
getFieldsetProperty(scope).value = scope.model.value;
// notify the linker that the property value changed
propertyValueChanged(getFieldset(scope), getFieldsetProperty(scope));
}
});
element.html(data).show();
+24
View File
@@ -0,0 +1,24 @@
angular.module("umbraco.directives").directive('archetypeSubmitWatcher', function ($rootScope) {
var linker = function (scope, element, attrs, ngModelCtrl) {
// call the load callback on scope to obtain the ID of this submit watcher
var id = scope.loadCallback();
scope.$on("formSubmitting", function (ev, args) {
// on the "formSubmitting" event, call the submit callback on scope to notify the Archetype controller to do it's magic
if (id == scope.activeSubmitWatcher) {
scope.submitCallback();
}
});
}
return {
restrict: "E",
replace: true,
link: linker,
template: "",
scope: {
loadCallback: '=',
submitCallback: '=',
activeSubmitWatcher: '='
}
}
});
+1
View File
@@ -40,6 +40,7 @@
<div ng-class="[(model.config.hidePropertyLabels == '1' ? 'controls-no-label' : 'controls')]">
<archetype-property class="archetypeEditor" property="property" property-editor-alias="model.alias" fieldset-index="$parent.$index" fieldset="fieldset" archetype-config="model.config" property-config-index="$index" archetype-render-model="model.value" umbraco-form="form"></archetype-property>
<archetype-submit-watcher active-submit-watcher="activeSubmitWatcher" load-callback="submitWatcherOnLoad" submit-callback="submitWatcherOnSubmit"></archetype-submit-watcher>
</div>
</div>
</form>
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "Archetype",
"version": "1.7.1",
"version": "1.7.3",
"url": "http://github.com/imulus/archetype/",
"author": "Imulus - Kevin Giszewski - Tom Fulton - Lee Kelleher - Matt Brailsford - Kenn Jacobsen - Et. Al.",
"authorUrl": "http://imulus.com/",
+1 -1
View File
@@ -22,7 +22,7 @@
"grunt-msbuild": "~0.1.9",
"grunt-dotnet-assembly-info": "~1.0.9",
"load-grunt-tasks": "~0.4.0",
"grunt-umbraco-package": "0.0.5"
"grunt-umbraco-package": "0.0.6"
},
"repository": {
"type": "git",