Don't let the users empty the recycle bin without delete permissions (#3699)

2019-01-22 22:05:12 +01:00
parent e252a0849b
commit a8d5bd6d1f
3 changed files with 15 additions and 2 deletions
@@ -346,8 +346,15 @@ namespace Umbraco.Web.Trees
        {
            if (RecycleBinId.ToInvariantString() == id)
            {
+                // get the default assigned permissions for this user
+                var actions = ActionsResolver.Current.FromActionSymbols(Security.CurrentUser.GetPermissions(Constants.System.RecycleBinContentString, Services.UserService)).ToList();
+
                var menu = new MenuItemCollection();
-                menu.Items.Add<ActionEmptyTranscan>(ui.Text("actions", "emptyTrashcan"));
+                // only add empty recycle bin if the current user is allowed to delete by default 
+                if (actions.Contains(ActionDelete.Instance))
+                {
+                    menu.Items.Add<ActionEmptyTranscan>(ui.Text("actions", "emptyTrashcan"));
+                }
                menu.Items.Add<ActionRefresh>(ui.Text("actions", ActionRefresh.Instance.Alias), true);
                return menu;
            }