From a293ff0200cb78b828ea8eebcbdf2d6414cbbdeb Mon Sep 17 00:00:00 2001
From: Mads Rasmussen <mads@umbraco.com>
Date: Tue, 29 May 2018 11:05:19 +0200
Subject: [PATCH] fix localisation of doc type subviews

---
 .../views/documenttypes/edit.controller.js    | 76 +++++++++++--------
 1 file changed, 46 insertions(+), 30 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/views/documenttypes/edit.controller.js b/src/Umbraco.Web.UI.Client/src/views/documenttypes/edit.controller.js
index 022196328e..1451a3d0c4 100644
--- a/src/Umbraco.Web.UI.Client/src/views/documenttypes/edit.controller.js
+++ b/src/Umbraco.Web.UI.Client/src/views/documenttypes/edit.controller.js
@@ -15,34 +15,7 @@
         var evts = [];
 
         var disableTemplates = Umbraco.Sys.ServerVariables.features.disabledFeatures.disableTemplates;
-
-        var buttons = [
-            {
-                "name": localizationService.localize("general_design"),
-                "alias": "design",
-                "icon": "icon-document-dashed-line",
-                "view": "views/documenttypes/views/design/design.html",
-                "active": true
-            },
-            {
-                "name": localizationService.localize("general_listView"),
-                "alias": "listView",
-                "icon": "icon-list",
-                "view": "views/documenttypes/views/listview/listview.html"
-            },
-            {
-                "name": localizationService.localize("general_rights"),
-                "alias": "permissions",
-                "icon": "icon-keychain",
-                "view": "views/documenttypes/views/permissions/permissions.html"
-            },
-            {
-                "name": localizationService.localize("treeHeaders_templates"),
-                "alias": "templates",
-                "icon": "icon-layout",
-                "view": "views/documenttypes/views/templates/templates.html"
-            }
-        ];
+        vm.labels = {};
 
         vm.save = save;
 
@@ -54,7 +27,50 @@
         vm.page.saveButtonState = "init";
         vm.page.navigation = [];
 
-        loadButtons();
+        var labelKeys = [
+            "general_design",
+            "general_listView",
+            "general_rights",
+            "treeHeaders_templates"
+        ];
+
+        localizationService.localizeMany(labelKeys).then(function (values) {
+            vm.labels.design = values[0];
+            vm.labels.listview = values[1];
+            vm.labels.permissions = values[2];
+            vm.labels.templates = values[3];
+
+            var buttons = [
+                {
+                    "name": vm.labels.design,
+                    "alias": "design",
+                    "icon": "icon-document-dashed-line",
+                    "view": "views/documenttypes/views/design/design.html",
+                    "active": true
+                },
+                {
+                    "name": vm.labels.listview,
+                    "alias": "listView",
+                    "icon": "icon-list",
+                    "view": "views/documenttypes/views/listview/listview.html"
+                },
+                {
+                    "name": vm.labels.permissions,
+                    "alias": "permissions",
+                    "icon": "icon-keychain",
+                    "view": "views/documenttypes/views/permissions/permissions.html"
+                },
+                {
+                    "name": vm.labels.templates,
+                    "alias": "templates",
+                    "icon": "icon-layout",
+                    "view": "views/documenttypes/views/templates/templates.html"
+                }
+            ];
+
+            loadButtons(buttons);
+
+        });
 
         vm.page.keyboardShortcutsOverview = [
             {
@@ -212,7 +228,7 @@
             });
         }
 
-        function loadButtons() {
+        function loadButtons(buttons) {
 
             angular.forEach(buttons,
                 function (val, index) {