From 650126cfc892bf1ec45b928d9c7904fc756c17cd Mon Sep 17 00:00:00 2001 From: Andy Butland Date: Fri, 10 Apr 2020 17:01:47 +0200 Subject: [PATCH] Amended PropertyBuilder to return IProperty and removed some unnecessary default properties from built test class. --- src/Umbraco.Tests.Common/Builders/PropertyBuilder.cs | 4 ++-- .../Umbraco.Infrastructure/Models/PropertyTests.cs | 5 +---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/Umbraco.Tests.Common/Builders/PropertyBuilder.cs b/src/Umbraco.Tests.Common/Builders/PropertyBuilder.cs index 400cf88281..6cb7a431f2 100644 --- a/src/Umbraco.Tests.Common/Builders/PropertyBuilder.cs +++ b/src/Umbraco.Tests.Common/Builders/PropertyBuilder.cs @@ -5,7 +5,7 @@ using Umbraco.Tests.Common.Builders.Interfaces; namespace Umbraco.Tests.Common.Builders { public class PropertyBuilder - : BuilderBase, + : BuilderBase, IBuildPropertyTypes, IWithIdBuilder, IWithKeyBuilder, @@ -26,7 +26,7 @@ namespace Umbraco.Tests.Common.Builders return builder; } - public override Property Build() + public override IProperty Build() { var id = _id ?? 1; var key = _key ?? Guid.NewGuid(); diff --git a/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Models/PropertyTests.cs b/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Models/PropertyTests.cs index 45ed2bd0aa..6d0e4f8d56 100644 --- a/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Models/PropertyTests.cs +++ b/src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Models/PropertyTests.cs @@ -38,13 +38,10 @@ namespace Umbraco.Tests.UnitTests.Umbraco.Infrastructure.Models } } - private Property BuildProperty() + private IProperty BuildProperty() { return _builder .WithId(4) - .WithKey(Guid.NewGuid()) - .WithCreateDate(DateTime.Now) - .WithUpdateDate(DateTime.Now) .AddPropertyType() .WithId(3) .WithPropertyEditorAlias("TestPropertyEditor")