From 4ff91ed4d1e4643998897dc6e347c132003839c9 Mon Sep 17 00:00:00 2001
From: Bjarne Fyrstenborg <bjarne_fyrstenborg@hotmail.com>
Date: Tue, 11 Feb 2020 20:15:22 +0100
Subject: [PATCH] Use button element in user detail and user group views
 (#7584)

* Use button element on user detail page

* Use button element on user group page
---
 .../src/views/users/group.html                | 59 ++++++++-----------
 .../src/views/users/views/user/details.html   | 32 +++++-----
 2 files changed, 40 insertions(+), 51 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/views/users/group.html b/src/Umbraco.Web.UI.Client/src/views/users/group.html
index 0244819655..8333528ddd 100644
--- a/src/Umbraco.Web.UI.Client/src/views/users/group.html
+++ b/src/Umbraco.Web.UI.Client/src/views/users/group.html
@@ -40,13 +40,12 @@
                                             on-remove="vm.removeSelectedItem($index, vm.userGroup.sections)">
                                         </umb-node-preview>
 
-                                        <a href=""
-                                            style="max-width: 100%;"
-                                            class="umb-node-preview-add"
-                                            ng-click="vm.openSectionPicker()"
-                                            prevent-default>
+                                        <button type="button"
+                                                class="umb-node-preview-add"
+                                                style="max-width: 100%;"
+                                                ng-click="vm.openSectionPicker()">
                                             <localize key="general_add">Add</localize>
-                                        </a>
+                                        </button>
                                     </umb-control-group>
 
                                     <umb-control-group style="margin-bottom: 20px;" label="@user_startnode" description="@user_startnodehelp">
@@ -61,15 +60,13 @@
                                             on-remove="vm.clearStartNode('content')">
                                         </umb-node-preview>
 
-                                        <a href=""
-                                            ng-if="!vm.userGroup.contentStartNode"
-                                            style="max-width: 100%;"
-                                            class="umb-node-preview-add"
-                                            ng-click="vm.openContentPicker()"
-                                            prevent-default>
+                                        <button type="button"
+                                                ng-if="!vm.userGroup.contentStartNode"
+                                                class="umb-node-preview-add"
+                                                style="max-width: 100%;"
+                                                ng-click="vm.openContentPicker()">
                                             <localize key="general_add">Add</localize>
-                                        </a>
-
+                                        </button>
                                     </umb-control-group>
 
                                     <umb-control-group label="@user_mediastartnode" description="@user_mediastartnodehelp">
@@ -85,14 +82,13 @@
                                             on-remove="vm.clearStartNode('media')">
                                         </umb-node-preview>
 
-                                        <a href=""
-                                            ng-if="!vm.userGroup.mediaStartNode"
-                                            style="max-width: 100%;"
-                                            class="umb-node-preview-add"
-                                            ng-click="vm.openMediaPicker()"
-                                            prevent-default>
+                                        <button type="button"
+                                                ng-if="!vm.userGroup.mediaStartNode"
+                                                class="umb-node-preview-add"
+                                                style="max-width: 100%;"
+                                                ng-click="vm.openMediaPicker()">
                                             <localize key="general_add">Add</localize>
-                                        </a>
+                                        </button>
 
                                     </umb-control-group>
 
@@ -127,13 +123,12 @@
                                             on-edit="vm.setPermissionsForNode(node)">
                                         </umb-node-preview>
 
-                                        <a href=""
-                                            style="max-width: 100%;"
-                                            class="umb-node-preview-add"
-                                            ng-click="vm.openGranularPermissionsPicker()"
-                                            prevent-default>
+                                        <button type="button"
+                                                class="umb-node-preview-add"
+                                                style="max-width: 100%;"
+                                                ng-click="vm.openGranularPermissionsPicker()">
                                             <localize key="general_add">Add</localize>
-                                        </a>
+                                        </button>
                                     </umb-control-group>
                                     
                                 </umb-box-content>
@@ -155,13 +150,11 @@
                                         on-remove="vm.removeSelectedItem($index, vm.userGroup.users)">
                                     </umb-user-preview>
 
-                                    <a href=""
-                                        style="max-width: 100%;"
-                                        class="umb-node-preview-add"
-                                        ng-click="vm.openUserPicker()"
-                                        prevent-default>
+                                    <button type="button"
+                                            class="umb-node-preview-add"
+                                            ng-click="vm.openUserPicker()">
                                         <localize key="general_add">Add</localize>
-                                    </a>
+                                    </button>
 
                                 </umb-box-content>
                             </umb-box>
diff --git a/src/Umbraco.Web.UI.Client/src/views/users/views/user/details.html b/src/Umbraco.Web.UI.Client/src/views/users/views/user/details.html
index e0cf09da50..bb3efaede2 100644
--- a/src/Umbraco.Web.UI.Client/src/views/users/views/user/details.html
+++ b/src/Umbraco.Web.UI.Client/src/views/users/views/user/details.html
@@ -75,13 +75,11 @@
                                             on-remove="model.removeSelectedItem($index, model.user.userGroups)">
                     </umb-user-group-preview>
 
-                    <a href=""
-                       style="max-width: 100%;"
-                       class="umb-node-preview-add"
-                       ng-click="model.openUserGroupPicker()"
-                       prevent-default>
+                    <button type="button"
+                            class="umb-node-preview-add"
+                            ng-click="model.openUserGroupPicker()">
                         <localize key="general_add">Add</localize>
-                    </a>
+                    </button>
 
                 </umb-control-group>
 
@@ -100,13 +98,12 @@
                                       name="model.labels.noStartNodes">
                     </umb-node-preview>
 
-                    <a href=""
-                       class="umb-node-preview-add"
-                       id="content-start-add"
-                       ng-click="model.openContentPicker()"
-                       prevent-default>
+                    <button type="button"
+                            class="umb-node-preview-add"
+                            id="content-start-add"
+                            ng-click="model.openContentPicker()">
                         <localize key="general_add">Add</localize>
-                    </a>
+                    </button>
 
                 </umb-control-group>
 
@@ -125,13 +122,12 @@
                                       name="model.labels.noStartNodes">
                     </umb-node-preview>
 
-                    <a href=""
-                       class="umb-node-preview-add"
-                       ng-click="model.openMediaPicker()"
-                       id="media-start-add"
-                       prevent-default>
+                    <button type="button"
+                            class="umb-node-preview-add"
+                            ng-click="model.openMediaPicker()"
+                            id="media-start-add">
                         <localize key="general_add">Add</localize>
-                    </a>
+                    </button>
 
                 </umb-control-group>