diff --git a/CHANGELOG.md b/CHANGELOG.md index e521e51..8c8e0ea 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +### 4.2.1 + +- fixes [issue #3](https://github.com/ceee/ReadSharp/issues/3) + ### 4.2.0 - use custom encoders if not supported on platform (implemented for ISO-8859 and Windows range). diff --git a/PortablePorts/NReadability/MetaExtractor.cs b/PortablePorts/NReadability/MetaExtractor.cs index 4984c2d..c061378 100644 --- a/PortablePorts/NReadability/MetaExtractor.cs +++ b/PortablePorts/NReadability/MetaExtractor.cs @@ -123,11 +123,14 @@ namespace ReadSharp.Ports.NReadability { "http-equiv|Content-Type", "content" } }); - int charsetStart = result.IndexOf("charset="); - if (charsetStart > 0) + if (!String.IsNullOrEmpty(result)) { - charsetStart += 8; - result = result.Substring(charsetStart, result.Length - charsetStart); + int charsetStart = result.IndexOf("charset="); + if (charsetStart > 0) + { + charsetStart += 8; + result = result.Substring(charsetStart, result.Length - charsetStart); + } } } diff --git a/ReadSharp.Tests/ReadTests.cs b/ReadSharp.Tests/ReadTests.cs index 830d193..1c1da30 100644 --- a/ReadSharp.Tests/ReadTests.cs +++ b/ReadSharp.Tests/ReadTests.cs @@ -119,5 +119,15 @@ namespace ReadSharp.Tests Article result = await reader.Read(new Uri("http://www.uelike.com")); Assert.Equal(result.Title, expectedTitle); } + + [Fact] + public async Task TestCriticalURIs() + { + Article result = await reader.Read(new Uri("http://www.jetbrains.com/resharper/whatsnew/index.html")); + Assert.NotEmpty(result.Content); + + result = await reader.Read(new Uri("http://msdn.microsoft.com/en-us/library/windows/apps/hh464925.aspx")); + Assert.NotEmpty(result.Content); + } } } \ No newline at end of file diff --git a/ReadSharp/Properties/AssemblyInfo.cs b/ReadSharp/Properties/AssemblyInfo.cs index 09a890c..3431abc 100644 --- a/ReadSharp/Properties/AssemblyInfo.cs +++ b/ReadSharp/Properties/AssemblyInfo.cs @@ -22,5 +22,5 @@ // You can specify all the values or you can default the Build and Revision Numbers // by using the '*' as shown below: // [assembly: AssemblyVersion("1.0.*")] -[assembly: AssemblyVersion("4.2.0")] -[assembly: AssemblyFileVersion("4.2.0")] \ No newline at end of file +[assembly: AssemblyVersion("4.2.1")] +[assembly: AssemblyFileVersion("4.2.1")] \ No newline at end of file