From 585c203f9ad5bf53a90f7cc2b82fd04d8e5f6bce Mon Sep 17 00:00:00 2001 From: Tobias Klika Date: Mon, 17 Feb 2014 23:30:15 +0100 Subject: [PATCH] fix PocketAction conversion exception when no ID is given; fixes #20 --- PocketSharp.Tests/ModifyTests.cs | 15 +++++++++++++++ PocketSharp/Models/PocketAction.cs | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/PocketSharp.Tests/ModifyTests.cs b/PocketSharp.Tests/ModifyTests.cs index a7615cd..7772a78 100644 --- a/PocketSharp.Tests/ModifyTests.cs +++ b/PocketSharp.Tests/ModifyTests.cs @@ -88,6 +88,21 @@ namespace PocketSharp.Tests } + [Fact] + public async Task AreMultipleAddActionsSent() + { + PocketItem item = await Setup(); + + bool success = await client.SendActions(new List() + { + new PocketAction() { Action = "add", Uri = new Uri("http://msdn.microsoft.com/en-us/library/windows/apps/jj841126.aspx") }, + new PocketAction() { Action = "add", Uri = new Uri("http://pokiapp.com/changelog") } + }); + + Assert.True(success); + } + + private async Task Setup() { PocketItem item = await client.Add( diff --git a/PocketSharp/Models/PocketAction.cs b/PocketSharp/Models/PocketAction.cs index 0783575..d030c8e 100644 --- a/PocketSharp/Models/PocketAction.cs +++ b/PocketSharp/Models/PocketAction.cs @@ -105,7 +105,7 @@ namespace PocketSharp.Models { "action", Action } }; - if (ID != "0" && !String.IsNullOrEmpty(ID.ToString())) + if (!String.IsNullOrEmpty(ID) && ID != "0") parameters.Add("item_id", ID.ToString()); if (Time != null) parameters.Add("time", Time != null ? Utilities.GetUnixTimestamp(Time).ToString() : null);