things

source/VMelnalksnis.NordigenDotNet/Accounts/BookedTransaction.cs

@@ -1,55 +0,0 @@
-// Copyright 2022 Valters Melnalksnis
-// Licensed under the Apache License 2.0.
-// See LICENSE file in the project root for full license information.
-
-using System;
-
-using NodaTime;
-
-using VMelnalksnis.NordigenDotNet.Institutions;
-
-namespace VMelnalksnis.NordigenDotNet.Accounts;
-
-/// <summary>A transaction that has been booked - posted to an account on the account servicer's books.</summary>
-public record BookedTransaction : Transaction
-{
-	/// <summary>Gets or sets a unique transaction id created by the <see cref="Institution"/>.</summary>
-	public string TransactionId { get; set; } = null!;
-	
-	/// <summary>Gets or sets a unique transaction id created by Nordigen.</summary>
-	public string InternalTransactionId { get; set; } = null!;
-
-	/// <summary>Gets or sets the date when an entry is posted to an account on the account servicer's books.</summary>
-	public DateTimeOffset BookingDate { get; set; }
-
-	/// <summary>Gets or sets the name of the counterparty that sends <see cref="Transaction.TransactionAmount"/> during the transaction.</summary>
-	public string? DebtorName { get; set; }
-
-	/// <summary>Gets or sets the account of the counterparty that sends <see cref="Transaction.TransactionAmount"/> during the transaction.</summary>
-	public TransactionAccount? DebtorAccount { get; set; }
-
-	/// <summary>Gets or sets the name of the counterparty that receives <see cref="Transaction.TransactionAmount"/> during the transaction.</summary>
-	public string? CreditorName { get; set; }
-
-	/// <summary>Gets or sets the account of the counterparty that receives <see cref="Transaction.TransactionAmount"/> during the transaction.</summary>
-	public TransactionAccount? CreditorAccount { get; set; }
-
-	/// <summary>Gets or sets the ISO 20022 bank transaction code.</summary>
-	/// <example>Some example values:
-	/// <code>
-	/// PMNT-ICDT-STDO
-	/// PMNT-IRCT-STDO
-	/// </code></example>
-	public string? BankTransactionCode { get; set; }
-
-	/// <summary>Gets or sets a transaction id, used both by the transaction and any fees paid to the <see cref="Institution"/> for the transaction.</summary>
-	public string? EntryReference { get; set; }
-
-	/// <summary>Gets or sets additional structured information about the transaction from the institution.</summary>
-	/// <example>
-	/// <code>
-	/// PURCHASE
-	/// INWARD TRANSFER
-	/// </code></example>
-	public string? AdditionalInformation { get; set; }
-}

source/VMelnalksnis.NordigenDotNet/Accounts/PendingTransaction.cs

@@ -1,8 +0,0 @@
-// Copyright 2022 Valters Melnalksnis
-// Licensed under the Apache License 2.0.
-// See LICENSE file in the project root for full license information.
-
-namespace VMelnalksnis.NordigenDotNet.Accounts;
-
-/// <summary>A transaction that is still pending.</summary>
-public record PendingTransaction : Transaction;

source/VMelnalksnis.NordigenDotNet/Accounts/Transaction.cs

@@ -10,7 +10,7 @@ using NodaTime;
 namespace VMelnalksnis.NordigenDotNet.Accounts;
 
 /// <summary>Common information for all transactions.</summary>
-public abstract record Transaction
+public record Transaction
 {
 	/// <summary>Gets or sets the amount transferred in this transaction.</summary>
 	public AmountInCurrency TransactionAmount { get; set; } = null!;
@@ -21,4 +21,49 @@ public abstract record Transaction
 
 	/// <summary>Gets or sets the date when the transaction was valued at.</summary>
 	public DateTimeOffset? ValueDate { get; set; }
+	
+	/// <summary>Gets or sets a unique transaction id created by the <see cref="Institution"/>.</summary>
+	public string TransactionId { get; set; } = null!;
+	
+	/// <summary>Gets or sets a unique transaction id created by Nordigen.</summary>
+	public string InternalTransactionId { get; set; } = null!;
+
+	/// <summary>Gets or sets the date when an entry is posted to an account on the account servicer's books.</summary>
+	public DateTimeOffset? BookingDate { get; set; }
+
+	/// <summary>Gets or sets the name of the counterparty that sends <see cref="Transaction.TransactionAmount"/> during the transaction.</summary>
+	public string? DebtorName { get; set; }
+
+	/// <summary>Gets or sets the account of the counterparty that sends <see cref="Transaction.TransactionAmount"/> during the transaction.</summary>
+	public TransactionAccount? DebtorAccount { get; set; }
+
+	/// <summary>Gets or sets the name of the counterparty that receives <see cref="Transaction.TransactionAmount"/> during the transaction.</summary>
+	public string? CreditorName { get; set; }
+
+	/// <summary>Gets or sets the account of the counterparty that receives <see cref="Transaction.TransactionAmount"/> during the transaction.</summary>
+	public TransactionAccount? CreditorAccount { get; set; }
+
+	/// <summary>Gets or sets the ISO 20022 bank transaction code.</summary>
+	/// <example>Some example values:
+	/// <code>
+	/// PMNT-ICDT-STDO
+	/// PMNT-IRCT-STDO
+	/// </code></example>
+	public string? BankTransactionCode { get; set; }
+
+	/// <summary>Gets or sets a transaction id, used both by the transaction and any fees paid to the <see cref="Institution"/> for the transaction.</summary>
+	public string? EntryReference { get; set; }
+
+	/// <summary>Gets or sets additional structured information about the transaction from the institution.</summary>
+	/// <example>
+	/// <code>
+	/// PURCHASE
+	/// INWARD TRANSFER
+	/// </code></example>
+	public string? AdditionalInformation { get; set; }
+}
+
+
+public record PendingTransaction : Transaction
+{
 }

source/VMelnalksnis.NordigenDotNet/Accounts/Transactions.cs

@@ -10,7 +10,7 @@ namespace VMelnalksnis.NordigenDotNet.Accounts;
 public record Transactions
 {
 	/// <summary>Gets or sets all transactions that have been booked.</summary>
-	public List<BookedTransaction> Booked { get; set; } = null!;
+	public List<Transaction> Booked { get; set; } = null!;
 
 	/// <summary>Gets or sets all transaction that are still pending.</summary>
 	public List<PendingTransaction> Pending { get; set; } = null!;